Skip to content

Comments

immich-go: 0.22.1 -> 0.25.0#392288

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
kai-tub:pkgs/immich-go/0.24.7
Mar 27, 2025
Merged

immich-go: 0.22.1 -> 0.25.0#392288
dotlambda merged 1 commit intoNixOS:masterfrom
kai-tub:pkgs/immich-go/0.24.7

Conversation

@kai-tub
Copy link
Contributor

@kai-tub kai-tub commented Mar 23, 2025 •
edited
Loading

Diff: simulot/immich-go@0.22.1...v0.25.0

Changelog: https://github.com/simulot/immich-go/releases/tag/v0.25.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes #391527 and should fix the update bot.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 23, 2025
@JayRovacsek
Copy link
Contributor

JayRovacsek commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392288

aarch64-darwin

❌ 1 package failed to build:
  • immich-go

@JayRovacsek
Copy link
Contributor

JayRovacsek commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 392288

aarch64-darwin

❌ 1 package failed to build:

* immich-go

FWIW the fail was caused during the checks phase, on TestCall/happy_path which was attempting to use a network port - I'd assume this fails within sandboxed settings always?

@kai-tub
Copy link
Contributor Author

kai-tub commented Mar 23, 2025

Dunno but of-borg passed 🤷
I don't have darwin.

dotlambda
dotlambda requested changes Mar 23, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.changelog needs to be updated (the link in the commit message 404s).
I suggest you reference src.tag in it rather than version.

@kai-tub kai-tub force-pushed the pkgs/immich-go/0.24.7 branch 2 times, most recently from 5f24c67 to 342c2e2 Compare March 24, 2025 07:39
dotlambda
dotlambda reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.25.0 was released

pkgs/by-name/im/immich-go/package.nix Outdated
Comment on lines 45 to 48
Copy link
Member

@dotlambda dotlambda Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preCheck = ''
export HOME=$TMPDIR
mkdir -p $HOME
'';
nativeCheckInputs = [
writableTmpDirAsHomeHook
];

and put this below preBuild

Copy link
Contributor Author

@kai-tub kai-tub Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reference! How could I have found this hook by myself?

Copy link
Member

@dotlambda dotlambda Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. It's pretty new afaik and I only stumbled on it by accident.

@dotlambda
Copy link
Member

dotlambda commented Mar 24, 2025 •
edited
Loading

the link in the commit message 404s

This is still true.
And the diff link should be simulot/immich-go@0.22.1...v0.24.7

@kai-tub kai-tub force-pushed the pkgs/immich-go/0.24.7 branch from 342c2e2 to fae6ef4 Compare March 25, 2025 06:50
@kai-tub kai-tub changed the title immich-go: 0.22.1 -> 0.24.7 immich-go: 0.22.1 -> 0.25.0 Mar 25, 2025
@kai-tub
Copy link
Contributor Author

kai-tub commented Mar 25, 2025

Thank you for catching all the silly mistakes. 🤦‍♂️ 👍
Should hopefully be fine now.

@kai-tub kai-tub force-pushed the pkgs/immich-go/0.24.7 branch from fae6ef4 to a28fe7c Compare March 25, 2025 06:56
@kai-tub kai-tub force-pushed the pkgs/immich-go/0.24.7 branch from a28fe7c to 00a3a62 Compare March 25, 2025 14:42
@dotlambda dotlambda merged commit 492533d into NixOS:master Mar 27, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: immich-go 0.22.1 → 0.24.2

3 participants

@kai-tub @JayRovacsek @dotlambda